Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up for TS tagged union support (#2618) #2623

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Follow-up for TS tagged union support (#2618) #2623

merged 1 commit into from
Nov 26, 2021

Conversation

cannorin
Copy link
Contributor

@cannorin cannorin commented Nov 26, 2021 •
edited
Loading

  • Erase the declaration of TypeScriptTaggedUnion
  • Check the tag when creating a TypeScriptTaggedUnion case

@alfonsogarciacaro Feel free to take over the second one If I'm too slow to implement it, since I'm still trying to figure out how to do that 😅 I think I will prioritize the docs over that.

@cannorin cannorin mentioned this pull request Nov 26, 2021
Merged
3 tasks
@cannorin
Copy link
Contributor Author

Also: fable-compiler/fable-compiler.github.io#116

@alfonsogarciacaro
Copy link
Member

Thanks again @cannorin! We probably can defer the tag checking to the next release 👍

@alfonsogarciacaro alfonsogarciacaro merged commit 44b38de into fable-compiler:main Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cannorin @alfonsogarciacaro