Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events break when named "Lunch" #8

Closed
hunterwilhelm opened this issue Dec 8, 2021 · 2 comments · Fixed by #10
Closed

Events break when named "Lunch" #8

hunterwilhelm opened this issue Dec 8, 2021 · 2 comments · Fixed by #10

Comments

@hunterwilhelm
Copy link
Contributor

Description

I named an event "Lunch" and the button doesn't work as expected because it has a background image that is messing up the CSS or HTML.

Reproduction

  1. Name an event "Lunch"
  2. Try to duplicate it
  3. You'll see that it looks strange and doesn't work when you click it.

Pictures

What it looks like without hover
Screen Shot 2021-12-08 at 10 45 41 AM

With hover
Screen Shot 2021-12-08 at 10 45 48 AM

Clicking option actually triggers it instead of duplicate.
Screen Shot 2021-12-08 at 10 46 28 AM

Environment

  • Version of extension: 1.0.3
  • macOS Big Sur
  • Chrome Version 96.0.4664.55 (Official Build) (x86_64)
@fabiosangregorio
Copy link
Owner

Hey @hunterwilhelm!
Nice catch, I think this may be due to a low z-index on the duplicate icon. As I mentioned in another issue, unfortunately as of now I'm too busy to further develop the extension, but if you are willing to put together a PR I'd be more than happy to help you out there and merge it!
Happy holidays 🎄

hunterwilhelm added a commit to hunterwilhelm/google-calendar-quick-duplicate that referenced this issue Jan 9, 2022
@hunterwilhelm
Fixes fabiosangregorio#8 functionality
bd94064
hunterwilhelm added a commit to hunterwilhelm/google-calendar-quick-duplicate that referenced this issue Jan 10, 2022
@hunterwilhelm
Fixes fabiosangregorio#8 visually
8c1a118
@hunterwilhelm hunterwilhelm mentioned this issue Jan 10, 2022
Merged
fabiosangregorio pushed a commit that referenced this issue Jan 16, 2022
@hunterwilhelm
Fixes #8: Events break when named "Lunch" (#10)
3ade5e9 
* Fixes #8 functionality

* Fixes #8 visually
@fabiosangregorio fabiosangregorio added the awaiting-release Awaiting release of the new version on the Chrome Web Store label Jan 16, 2022
@fabiosangregorio
Copy link
Owner

Released in 1.1.0

@fabiosangregorio fabiosangregorio removed the awaiting-release Awaiting release of the new version on the Chrome Web Store label Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #8: Events break when named "Lunch" hunterwilhelm/google-calendar-quick-duplicate
2 participants
@fabiosangregorio @hunterwilhelm