384: Make nocache optional

[jcarizza]

---

name: Make nocache optional
about: Ignore nocache based in a settings flag to not corrupt the S3 querysting signed URL
assignees: fabiocaccamo

---

Describe your changes

• Added a setting flag
• Change templates to not include md5 hash

Related issue
#384

Checklist before requesting a review

• I have performed a self-review of my code.
• I have added tests for the proposed changes.
• I have run the tests and there are not errors.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (3293bea) to head (566bc8b).
Report is 63 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
+ Coverage   97.35%   97.39%   +0.04%     
==========================================
  Files          38       38              
  Lines         416      423       +7     
==========================================
+ Hits          405      412       +7     
  Misses         11       11              

Flag	Coverage Δ
unittests	97.39% <100.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fabiocaccamo]

@jcarizza instead of adding a new setting, I would add a new template tag admin_interface_static which wraps the static template tag and that automatically adds the nocache parameter only if the url starts with STATIC_URL settings (simple yet effective and zero configuration needed).

I'm sorry that you worked in another direction, I would suggest you to discuss the solution in the issue before working on a PR the next time, anyway... thank you very much for this PR!

[jcarizza]

Hi @fabiocaccamo

Sorry I sent the PR before a previous discussion, I needed to fix that ASAP in my application.

I think this solution would be less intrusive and simpliest.

The new template tag will check if the files are the default django storage or if they start with STATIC_URL and add or remove the nocache tag.

[fabiocaccamo]

@jcarizza any update?