Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collapsible inlines support. #282

Merged
merged 6 commits into from
May 10, 2023
Merged

Add collapsible inlines support. #282

merged 6 commits into from
May 10, 2023

Conversation

fabiocaccamo
Copy link
Owner


name: Pull request
about: Submit a pull request for this project
assignees: fabiocaccamo


Describe your changes
This PR brings the following improvements:

  • it's possible to make inlines collapsible (via theme admin option)
  • it's possible to make collapsible inlines collapsed by default (via theme admin option)
  • it's possible to set both options (collapsible/collapsed) separately for stacked and tabular inlines

Related issue
Fix #263

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests for the proposed changes.
  • I have run the tests and there are not errors.

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (a8897a9) 97.29% compared to head (f5d4e6d) 97.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
+ Coverage   97.29%   97.34%   +0.05%     
==========================================
  Files          37       38       +1     
  Lines         406      414       +8     
==========================================
+ Hits          395      403       +8     
  Misses         11       11              
Flag Coverage Δ
unittests 97.34% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
admin_interface/admin.py 100.00% <ø> (ø)
...0030_theme_collapsible_stacked_inlines_and_more.py 100.00% <100.00%> (ø)
admin_interface/models.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fabiocaccamo fabiocaccamo merged commit a48575e into main May 10, 2023
@fabiocaccamo fabiocaccamo deleted the collapsible-inlines branch July 13, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapsible inlines.
1 participant