Do not assume active DB when not specified

[VaZark]

Related to #208

Let Django decide the current DB when not specified in the function call.

• Test with DB Router

[codecov]

Codecov Report

Base: 95.58% // Head: 95.58% // No change to project coverage 👍

Coverage data is based on head (bc95b3c) compared to base (18f865b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files          36       36           
  Lines         408      408           
=======================================
  Hits          390      390           
  Misses         18       18           

Flag	Coverage Δ
unittests	95.58% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
admin_interface/models.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[fabiocaccamo]

Could you add also a test case?

[VaZark]

Could you add also a test case?

Yup. Just added a testcase with a DB Router

[fabiocaccamo]

• Should run pre-commit run -a before commit files.
• Tests are broken with older Python / Django versions.

[fabiocaccamo]

@VaZark could you fix tests?

[VaZark]

Older versions of Django (<2.0) aren't throwing an exception when hitting a non-specified DB in a test case

class AdminInterfaceModelsWithDBRoutingTestCase(TestCase):
         databases = ["replica"]

Are you aware if there exists a different parameter to be used to specify active DB in older versions of Django ??

Or a way to skip the test for django < 2.0 ?

[merwok]

I always forget that this project supports ancient versions of Django!

https://www.djangoproject.com/download/#supported-versions

[fabiocaccamo]

@VaZark you can skip the test using unittest.skipIf decorator:
https://docs.python.org/3/library/unittest.html?highlight=skip#unittest.skip

@merwok it's already my intention to drop support for django versions < 2.2.

[VaZark]

I added the skip in the latest commit for django older than 2.0