Fix FSDP for GPTQ-LoRA and Fused Ops #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* workaround low-mem patch * resolve conflicts and define patch function * resolve conflicts and define patch function * Apply suggestions from code review Co-authored-by: Yu Chin Fabian Lim <fabianlim@users.noreply.github.com> * revert hack to avoid low memory bug in HF memory metrics calculation * reversed formatting * reverse more formatting --------- Co-authored-by: Yu Chin Fabian Lim <fabianlim@users.noreply.github.com>
…l-stack#27) * group memory field names with prefix and minor fixes * change to drop index on index reset
…oundation-model-stack#25) * initial commit Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> * add fast quantized plugin Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> * add mistral and fix plugin Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> * add licensing notices and instructions for adding new plugin. Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> * handle linting, formatting Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> * 2nd round of linting Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> * activate workflow and some more lint fixes Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> * add sample config Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> * updates to benchmark, scenarios Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> * fix tests Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com> --------- Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As foundation-model-stack#15 mentions there is a casting issue when using GPTQ-LoRA and Fused ops.
This issue occurs in fused ops because we bypass the base layer's forward, which we introduced a
reinterpret_castin the above mentioned issue:patch_forward_to_view_attributes_before_callto allow us to patch multiple submodules, this is needed for fused ops because these fowards trigger on the attention module, not on the linear modules directly.