Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hideous synchronous request #48

Closed
KTachyon opened this issue Aug 28, 2014 · 1 comment
Closed

Hideous synchronous request #48

KTachyon opened this issue Aug 28, 2014 · 1 comment

Comments

@KTachyon
Copy link

Hi,

I have been using PDF.js' viewer to display PDF files and I found out it was using this library. I have an issue with the synchronous request. I believe that nothing should ever block the Javascript thread, no matter what, and using a synchronous XHR request is a really bad idea.

I'm currently working on a local server that shares the same thread with Javascript, so the synchronous request ended up causing a deadlock. So, in order to fix my issue, I have forked the project and fixed it for my scenario. I believe it should work for requesting multiple .properties files, but I have not tested it, since I'm on a very tight schedule, so I'm not creating a pull request at the moment. If anyone is interested in fixing this, you can find my solution to this problem at https://github.com/KTachyon/webL10n

Rob--W added a commit to Rob--W/webL10n that referenced this issue Feb 18, 2015
If gAsyncResourceLoading is true, all requests must be asynchronous,
including requests generated by @import.
fabi1cazenave added a commit that referenced this issue Feb 20, 2015
Always respect gAsyncResourceLoading flag #48, r=kaze
@Rob--W
Copy link
Collaborator

Rob--W commented Feb 20, 2015

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants