Support finding children in properties #2
Conversation
|
Could you elaborate on where this is needed for Loaders? There is an example in Spix where the property of an item inside a Loader is queried and that seems to work fine and the items loaded by the Loader are part of the tree searched by Do you have a different usecase? In general I do like this syntax. Also thought about introducing |
| QQuickItem* repeater = static_cast<QQuickItem*>(root); | ||
| subItem = spix::qt::RepeaterChildWithName(repeater, QString::fromStdString(itemName)); | ||
| if (itemName.compare(0, 1, ".") == 0) { | ||
| QVariant propValue = root->property(itemName.c_str() + 1); |
There was a problem hiding this comment.
Please make this a bit more verbose and do something like
auto propertyName = itemName.substr(1);
QVariant propValue = root->property(propertyName.c_str());
I know this is more inefficient, but I think efficiency is not so crucial in this part of the code.
There was a problem hiding this comment.
Never mind, I will quickly change this myself and merge this PR.
Commits msg before squash (older to newer): Add possibility to find children in CONTEXT properties (extend PR faaxm#2) Add possibility to get direct contextProperty (which aren't object) Add better logs for getStringProperty Add Object and QtObject classes Change getStringProperty to use spix::QtObject class, regression in getting direct context properties and in error logging Adapt logs writing and access to context properties to QtObject::stringProperty method Allow to access to children OF object in context properties by assigning found child to subItem instead of returning Make QtObject::stringProperty less method-specific by returning logs WITHOUT method name inside
I'm not sure if you'll like this conceptually...
I'm trying to solve a problem of accessing objects "hidden" behind StackViews/Loaders, because
findChild()cannot see them.This adds support for using property names in paths - for example:
myApp/stackView/.currentItem/someButton