Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MpiWorld::destroy()
method was working alright until tested from faasm in faasm/faasm#420. There, I add abarrier
before callingdestroy()
. However, our barrier implementation is not fully blocking (ironic).The way barrier works is:
Before the broadcast is issued, all non-zero ranks are blocked on a
recv
, however rank 0 does asend
(which does not block) and exits the barrier before the other ranks have actually received the barrier. Thus, if this takes a long time, and we clear all the in memory queues before that, undefined behaviour happens.