cleaning up workflow file

faasm · Nov 25, 2021 · 135b66d · 135b66d
1 parent 949cb34
commit 135b66d
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 22 deletions.
diff --git a/.github/workflows/sanitisers.yml b/.github/workflows/sanitisers.yml
@@ -33,7 +33,7 @@ jobs:
       - name: "Ping redis"
         run: redis-cli -h redis ping
       # --- Build with thread sanitising
-      - name: "Build tests with leak sanitising"
+      - name: "Build tests with address sanitising"
         run: inv dev.sanitise Address
       # --- Tests ---
       - name: "Run tests with address sanitising on and print to stderr to file"
@@ -114,11 +114,8 @@ jobs:
       - name: "Run tests with undefined sanitising on and print stderr to file"
         run: ./bin/faabric_tests > /dev/null # 2> ./ubsan.log
         working-directory: /build/faabric/static
-        #       - name: "DELETE ME"
-        #         run: cat ./ubsan.log
-        #       # --- Compare with expected output
-        #       - name: "Compare with expected output"
-        #         run: diff ./ubsan.log ./tests/sanitise/expected_ubsan.log
+        env:
+          UBSAN_OPTIONS: "print_stacktrace=1:halt_on_error=1"
 
   leak-sanitiser:
     if: github.event.pull_request.draft == false
@@ -149,13 +146,8 @@ jobs:
         run: inv dev.sanitise Leak
       # --- Tests ---
       - name: "Run tests with leak sanitising on and print stderr to file"
-        run: ./bin/faabric_tests > /dev/null # 2> ./leaksan.log
+        run: ./bin/faabric_tests > /dev/null
         working-directory: /build/faabric/static
-        #       - name: "DELETE ME"
-        #         run: cat ./leaksan.log
-        #       # --- Compare with expected output
-        #       - name: "Compare with expected output"
-        #         run: diff ./leaksan.log ./tests/sanitise/expected_leaksan.log
 
   memory-sanitiser:
     if: github.event.pull_request.draft == false
@@ -188,8 +180,3 @@ jobs:
       - name: "Run tests with memory sanitising on and print stderr to file"
         run: ./bin/faabric_tests > /dev/null # 2> ./memsan.log
         working-directory: /build/faabric/static
-        #       - name: "DELETE ME"
-        #         run: cat ./memsan.log
-        #       # --- Compare with expected output
-        #       - name: "Compare with expected output"
-        #         run: diff ./memsan.log ./tests/sanitise/expected_memsan.log
diff --git a/tests/sanitise/expected_addsan.log b/tests/sanitise/expected_addsan.log
diff --git a/tests/sanitise/expected_leaksan.log b/tests/sanitise/expected_leaksan.log
diff --git a/tests/sanitise/expected_memsan.log b/tests/sanitise/expected_memsan.log
diff --git a/tests/sanitise/expected_threadsan.log b/tests/sanitise/expected_threadsan.log
diff --git a/tests/sanitise/expected_ubsan.log b/tests/sanitise/expected_ubsan.log