cmake list misses a necessary package

[csylvain]

{Ubuntu 22.04}
build stops because of missing header file

[homedir]/Software/sdrangel/sdrbase/util/osndb.cpp:21:10: fatal error: QtGui/private/qzipreader_p.h: No such file or directory
   21 | #include <QtGui/private/qzipreader_p.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [sdrbase/CMakeFiles/sdrbase.dir/build.make:2155: sdrbase/CMakeFiles/sdrbase.dir/util/osndb.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:4205: sdrbase/CMakeFiles/sdrbase.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

cmake list should check for package qtbase5-private-dev

$ apt-file find qzipreader_p.h
qtbase5-private-dev: /usr/include/x86_64-linux-gnu/qt5/QtGui/5.15.3/QtGui/private/qzipreader_p.h

[f4exb]

I think this is not possible to detect. This thread concludes that the problem persists after various workarounds were attempted: LMMS/lmms#4273

I suggest you follow instructions in the wiki https://github.com/f4exb/sdrangel/wiki/Compile-from-source-in-Linux where this dependency is explicitly stated.

[csylvain]

"Please check your Qt installation." <-- it was as Ubuntu 22.04 installs packages to run Qt Apps. I made changes as Cmake indicated after cloning the repo (added packages which were not found by Cmake). LMMS/lmms#4273 (comment) appears to show a workaround equivalent to simple hack of checking in Cmake the file QtGui/private/qzipreader_p.h exists. It is bad for Cmake to generate a Makefile when there are missing necessary components, yes? oh, and yes, thank you for pointing out the explicit list of dependencies in the Wiki. i suppose it may have been better to have cut-and-pasted rather than let Cmake guide me to missing packages. :-/

…

On Mon, May 15, 2023 at 3:32 AM Edouard Griffiths ***@***.***> wrote: I think this is not possible to detect, This threads concludes that the problem persists after various workarounds were attempted: LMMS/lmms#4273 <LMMS/lmms#4273> I suggest you follow instructions in the wiki https://github.com/f4exb/sdrangel/wiki/Compile-from-source-in-Linux where this dependency is explicitly stated. — Reply to this email directly, view it on GitHub <#1691 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABRUYNO3NTAFQVDVAUDXBO3XGHLZTANCNFSM6AAAAAAX5HISSA> . You are receiving this because you authored the thread.Message ID: ***@***.***>