Skip to content

Commit

Permalink
requests pulls in urllib3 2.x but that fails with an error
Browse files Browse the repository at this point in the history
They say 1.26.x will be maintained for a while.  To fix, someone needs
to figure out what the exact problem is as shown in:
psf/requests#6443 (comment)

I suppose there will need to be some change related to the urllib 2.x
migration, but it is unclear to me which.  The usage of requests in
fdroid/sdkmanager is quite simple.
https://urllib3.readthedocs.io/en/latest/v2-migration-guide.html
  • Loading branch information
eighthave committed May 30, 2023
1 parent 46de060 commit c560490
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def run(self):
entry_points={'console_scripts': ['sdkmanager=sdkmanager:main']},
python_requires='>=3.5',
cmdclass={'versioncheck': VersionCheckCommand},
install_requires=['argcomplete', 'requests > 2.12.2, != 2.18.0'],
install_requires=['argcomplete', 'requests > 2.12.2, != 2.18.0', 'urllib3<2'],
extras_require={'test': ['defusedxml', 'requests-cache']},
classifiers=[
'Development Status :: 4 - Beta',
Expand Down

0 comments on commit c560490

Please sign in to comment.