-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SocketIDをイベントとして取得できるように修正 #10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0054285
to
57bf002
Compare
4c4136d
to
b1b148b
Compare
11 tasks
この3つの説明が読むだけで分からなったので修正お願いしたいです。主に以下の観点です。
|
sus-taguchi-t
suggested changes
Dec 20, 2023
mahaweilu
reviewed
Dec 20, 2023
sasuke9410
commented
Dec 20, 2023
sus-taguchi-t
approved these changes
Jan 9, 2024
37577e6
to
1529bc7
Compare
kiyohome
requested changes
Jan 10, 2024
3 tasks
kiyohome
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
何の変更を加えましたか?
何を確認しましたか?
実装
テスト
変更影響
レビュアーへのメッセージ