Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a filesystem plugin #14

Merged
merged 4 commits into from
Jul 25, 2024
Merged

feat: add a filesystem plugin #14

merged 4 commits into from
Jul 25, 2024

Conversation

mhmd-azeez
Copy link
Contributor

No description provided.

@mhmd-azeez mhmd-azeez requested a review from zshipko July 21, 2024 11:24
Makefile Outdated
Comment on lines 23 to 29
@ls target/wasm32-wasi/release/*.wasm | while read name; do \
cp $$name plugins/; \
done
@ls target/wasm32-wasi/debug/*.wasm | while read name; do \
export newFilename=$$(echo $$name | sed 's/\.wasm/.debug.wasm/g'); \
cp $$name plugins/$$(basename $$newFilename); \
done
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like it will overwrite all the wasm32-unknown-unknown plugins with the wasm32-wasi ones

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch! fixed

@mhmd-azeez mhmd-azeez requested a review from zshipko July 25, 2024 08:23
@mhmd-azeez mhmd-azeez merged commit de215b0 into main Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants