Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better error message when wasm-merge not found #41

Merged
merged 1 commit into from
Jan 12, 2024
Merged

fix: better error message when wasm-merge not found #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ members = [
]

[workspace.package]
version = "1.0.0-rc4"
version = "1.0.0-rc5"
edition = "2021"
authors = ["The Extism Authors"]
license = "BSD-Clause-3"
Expand Down
5 changes: 5 additions & 0 deletions crates/cli/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,11 @@ fn main() -> Result<()> {
&import_shim_path,
)?;

let output = Command::new("wasm-merge").arg("--version").output();
if let Err(_) = output {
bail!("Failed to execute wasm-merge. Please install binaryen and make sure wasm-merge is on your path: https://github.com/WebAssembly/binaryen");
}

// Merge the export shim with the core module
let mut command = Command::new("wasm-merge")
.arg(&core_path)
Expand Down
Loading