Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extism .NET PDK Beta #4

Merged
merged 34 commits into from
Sep 26, 2023
Merged

Extism .NET PDK Beta #4

merged 34 commits into from
Sep 26, 2023

Conversation

mhmd-azeez
Copy link
Collaborator

@mhmd-azeez mhmd-azeez commented Aug 18, 2023

  • Implement all of the PDK functions
  • Allow users to import functions: We are now using DllImport instead of [MethodImpl(MethodImplOptions.InternalCall)] and we are also targeting .NET 8 now.
  • Make sure Mono.Cecil is not copied to plugin output dir
  • For some reason, the Rust runtime can't run .NET plugins after v0.1. I am not sure what has changed between 0.1 and 0.2. I am using the Go SDK to run the samples. This was because Mono expects at least one command line argument. I have wrapped mono_runtime_run_main to ensure that we pass at least one argument
  • Write some instructions in the README
  • Link to discord in the README
  • Create CI action
  • Test the nuget package locally
  • Create release action

@mhmd-azeez mhmd-azeez requested review from bhelx and zshipko August 18, 2023 07:39
@mhmd-azeez mhmd-azeez self-assigned this Aug 18, 2023
@zshipko
Copy link
Contributor

zshipko commented Aug 18, 2023

I'm curious what the error from the Rust runtime is?

I will try to get an environment to run this setup on my machine!

@mhmd-azeez
Copy link
Collaborator Author

@zshipko

I'm curious what the error from the Rust runtime is?

as we discussed before, the issue was this: https://github.com/dotnet/runtime/blob/4101144c8dde177addfb93ac46425fd1a8604f7a/src/mono/mono/metadata/object.c#L4175

This is now fixed in: 804c738

Side note: it seems like wasmtime passes its own command line args along to the module. e.g: wasmtime run plugin.wasm.

@mhmd-azeez mhmd-azeez marked this pull request as ready for review September 24, 2023 13:47
@mhmd-azeez
Copy link
Collaborator Author

@zshipko @bhelx
Alright, I think this PR is ready for your review folks! It has taken shape pretty nicely :)

This was referenced Sep 25, 2023
@bhelx bhelx merged commit 5a0dd61 into master Sep 26, 2023
@mhmd-azeez mhmd-azeez deleted the feat/pdk-functions branch September 26, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants