-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: images showing when mouse is off image link #1515
Conversation
LiliaDoe
commented
Dec 29, 2024
- This might fix the issue described in Add mouse click action key for right/middle mouse button #1489 (comment)
Quality Gate passedIssues Measures |
This PR fixed the problem, so I'm merging it. |
Glad to hear! |
@LiliaDoe I spoke too soon, I'm still seeing this problem. Repro steps (can repro on reddit as well but this one is easier):
Observed: the zoomed mage is still displayed even though the mouse is no longer hovering over it. |
Ok, I can reproduce it consistently now. |
I believe I found the source of the issue: Lines 1074 to 1086 in 4cb6b61
changing it back to how it was prior made it behave as expected for me: Lines 1071 to 1074 in 6b9717e
While it's not from my commit, I will work on a fix for it. |
Thank you for finding the root cause. I thought I bi-sected the problem to your commit, but I guess I made a mistake while doing that. Please accept my apologies! |
…ge (#1516) - This fixes what #1515 was trying to fix - setLoadImage used to set loadHoveredImage within callback so timeout can be set outside of callback. This makes clearTimeout use the correct timeout ID - There is probably a smarter way of fixing this, but this works --------- Co-authored-by: Oleg Anashkin <github@oleg.anashkin.org>