Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hide details and captions with full zoom #1481

Conversation

LiliaDoe
Copy link
Contributor

@LiliaDoe LiliaDoe commented Nov 27, 2024

  • Adds an option to hide captions and details when full zoom is pressed. This will let the image expand vertically a little more.
  • Partially fixes a slight vertical shift when full zoom is pressed
  • Updates some formatting

@LiliaDoe LiliaDoe marked this pull request as ready for review November 27, 2024 21:06
@LiliaDoe LiliaDoe marked this pull request as draft November 27, 2024 21:07
@LiliaDoe LiliaDoe marked this pull request as ready for review December 5, 2024 05:03
Copy link

gitguardian bot commented Dec 5, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
311104 Triggered Generic High Entropy Secret 78b2909 plugins/flickr_a.js View secret
8544155 Triggered Generic High Entropy Secret 78b2909 plugins/flickr_a.js View secret
311107 Triggered Generic High Entropy Secret 78b2909 plugins/flickr_a.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

sonarqubecloud bot commented Dec 5, 2024

@extesy extesy merged commit 70917f5 into extesy:master Dec 5, 2024
3 checks passed
@LiliaDoe LiliaDoe deleted the Add-option-to-hide-details-and-captions-with-full-zoom branch December 5, 2024 22:55
@LiliaDoe LiliaDoe restored the Add-option-to-hide-details-and-captions-with-full-zoom branch December 30, 2024 23:52
@LiliaDoe LiliaDoe deleted the Add-option-to-hide-details-and-captions-with-full-zoom branch December 31, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants