-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightway-core: Ignore wire::Frame::Data{Frag}
until State::Online
#126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data packets (whether fragmented or not) received from outside should not be forwarded out of the inside path until the connection is `Online` or after it has begun the disconnect process. We already correctly do this for data received on the inside path, in `Connection::inside_data_received`.
Code coverage summary for a9dcf11:
✅ Region coverage 57% passes |
xv-raihaan-m
approved these changes
Nov 14, 2024
kp-mariappan-ramasamy
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Data packets (whether fragmented or not) received from outside should not be forwarded out of the inside path until the connection is
Online
or after it has begun the disconnect process.We already correctly do this for data received on the inside path, in
Connection::inside_data_received
.Motivation and Context
Traffic should only flow across an Online connection.
How Has This Been Tested?
e2e tests continue to pass.
Types of changes
Checklist:
main