lightway-client: Register Ctrl-C handler later #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code coverage summary for e0ccd5c: ✅ Region coverage 60% passes |
... right before the main event loop begins. I used the wrong IP address in a test and was therefore blocking before reaching the mainloop, in `io::outside::Tcp::new`, I suppose TCP would eventually have timed out but in the meantime I was unable to Ctrl-C out of it since the handler had been registered but nothing was yet receiving from `ctrlc_rx`. By defering the registration we leave the default OS behaviour (term the process) in place until we are ready to deal with things ourselves. It can be reproduced with the following if there is no server running: ```console $ sudo ip netns exec lightway-client ./target/debug/lightway-client --config-file tests/client/client_config.yaml --mode tcp --ca-cert ca.crt --server 192.168.100.1:443 ``` I don't think there is a similar failure mode for the server side, since it receives rather than initiates connections, but make the same change there nonetheless, there might be other similar issues with another step of the setup process.
0bc4bf4 to
e0ccd5c
Compare
kp-mariappan-ramasamy
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... right before the main event loop begins.
I used the wrong IP address in a test and was therefore blocking before reaching the mainloop, in
io::outside::Tcp::new, I suppose TCP would eventually have timed out but in the meantime I was unable to Ctrl-C out of it since the handler had been registered but nothing was yet receiving fromctrlc_rx. By defering the registration we leave the default OS behaviour (term the process) in place until we are ready to deal with things ourselves.It can be reproduced with the following if there is no server running:
$ sudo ip netns exec lightway-client ./target/debug/lightway-client --config-file tests/client/client_config.yaml --mode tcp --ca-cert ca.crt --server 192.168.100.1:443I don't think there is a similar failure mode for the server side, since it
receives rather than initiates connections, but make the same change there
nonetheless, there might be other similar issues with another step of the setup
process.
Types of changes