-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix external links to strongloop.com (expressjs#1727) #1728
Conversation
https links to strongloop.com are broken, and http links redirect to the root of kyndryl.com. This commit wraps all strongloop links with archive.org links. The links are set to pull the latest versions archived as of 2024-01-01 (it looks like the site was last successfully archived at the end of 2023).
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this hotfix @johnburnett! I assume that maybe we want to remove the references in the next version of the website @expressjs/docs-captains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really wish #1679 would be merged instead of sending it to webarchive
#1679 still has broken links though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had forgotten about the translations in that PR
actually I misread -- the file you changed in the other PR indeed no longer has references to |
Since this fixes the 404, I’m going to merge this |
thank you @johnburnett |
Thanks all, and just a follow up note, it was good to see #1679. I’m coming at all this as a complete novice to the ecosystem, and guidance is exactly the kind of thing I’m needing at this point. |
https links to strongloop.com are broken, and http links redirect to the root of kyndryl.com.
This commit wraps all strongloop links with archive.org links. The links are set to pull the latest versions archived as of 2024-01-01 (it looks like the site was last successfully archived at the end of 2023).