Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external links to strongloop.com (expressjs#1727) #1728

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

johnburnett
Copy link
Contributor

https links to strongloop.com are broken, and http links redirect to the root of kyndryl.com.

This commit wraps all strongloop links with archive.org links. The links are set to pull the latest versions archived as of 2024-01-01 (it looks like the site was last successfully archived at the end of 2023).

https links to strongloop.com are broken, and http links redirect to the
root of kyndryl.com.

This commit wraps all strongloop links with archive.org links.  The
links are set to pull the latest versions archived as of 2024-01-01 (it
looks like the site was last successfully archived at the end of 2023).
Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 1090e36
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/67846aacd56e310008b4cab9
😎 Deploy Preview https://deploy-preview-1728--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this hotfix @johnburnett! I assume that maybe we want to remove the references in the next version of the website @expressjs/docs-captains

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really wish #1679 would be merged instead of sending it to webarchive

@ctcpip
Copy link
Member

ctcpip commented Jan 13, 2025

@bjohansebas

#1679 still has broken links though

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had forgotten about the translations in that PR

@ctcpip
Copy link
Member

ctcpip commented Jan 13, 2025

actually I misread -- the file you changed in the other PR indeed no longer has references to strongloop.com.

@bjohansebas
Copy link
Member

Since this fixes the 404, I’m going to merge this

@bjohansebas bjohansebas merged commit f01c3da into expressjs:gh-pages Jan 13, 2025
11 checks passed
@bjohansebas
Copy link
Member

thank you @johnburnett

@johnburnett
Copy link
Contributor Author

Thanks all, and just a follow up note, it was good to see #1679. I’m coming at all this as a complete novice to the ecosystem, and guidance is exactly the kind of thing I’m needing at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants