Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove broken link for error handling #1358

Merged
merged 30 commits into from
Mar 4, 2024

Conversation

aroyan
Copy link
Contributor

@aroyan aroyan commented Aug 7, 2022

Remove broken link in Performance Best Practices Using Express in Production on Handle exceptions properly section, there is a link point to Error Handling in Node.js but the page is not found now and I can't find a replacement for this so I think this is better to be removed

@dougwilson
Copy link
Contributor

Great find! Looks like Joyent moved their aite around and here is the new url: https://www.tritondatacenter.com/node-js/production/design/errors

@aroyan
Copy link
Contributor Author

aroyan commented Aug 7, 2022

Great find! Looks like Joyent moved their aite around and here is the new url: https://www.tritondatacenter.com/node-js/production/design/errors

Thank you, can't found them before. It's updated now

Copy link

@dhruvilxcode dhruvilxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@aroyan aroyan requested a review from dhruvilxcode December 1, 2022 01:59
Copy link

@dhruvilxcode dhruvilxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@crandmck crandmck self-requested a review March 4, 2024 01:38
@crandmck crandmck merged commit 7dcb726 into expressjs:gh-pages Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants