feat: Moving types into the repo #6382
Draft
+1,375
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
RobinTail
commented
Mar 9, 2025
RobinTail
commented
Mar 9, 2025
RobinTail
commented
Mar 9, 2025
Comment on lines
+8
to
+9
| /// <reference types="./core" /> | ||
| /// <reference types="serve-static" /> |
There was a problem hiding this comment.
these lines are for old versions of TypeScript, presumably v1.x
I believe we can get rid of them, as well as the installed @types/* dev dependencies on the next step.
RobinTail
commented
Mar 9, 2025
| "after": "0.8.2", | ||
| "connect-redis": "^8.0.1", | ||
| "cookie-parser": "1.4.7", | ||
| "cookie-session": "2.0.0", | ||
| "ejs": "^3.1.10", | ||
| "eslint": "8.47.0", | ||
| "eslint": "8.57.1", |
There was a problem hiding this comment.
this was required to install typescript-eslint.
But in general, I suggest upgrading to v9 (latest) in the future and migrating to flat config.
There was a problem hiding this comment.
We have an active discussion about changing it, see expressjs/discussions#327.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address expressjs/discussions#192 , labeled as "top priority".
express.query— it was removed in 5.0.0-alpha.1express.querytype forexpressv5 DefinitelyTyped/DefinitelyTyped#72159typescript-eslint(ESLint updates and configured)