Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix strict mode for node version past 0.10 #53

Merged
merged 2 commits into from
Jul 20, 2015
Merged

fix strict mode for node version past 0.10 #53

merged 2 commits into from
Jul 20, 2015

Conversation

jordandenison
Copy link
Contributor

set param to object when non object passed in to middlewareWrapper to fix issue with strict mode when a primitive value gets passed in to middlewareWrapper and causes this error:

/node_modules/cors/lib/index.js:188
o.origin = defaults.origin;
^
TypeError: Cannot assign to read only property 'origin' of true

troygoode added a commit that referenced this pull request Jul 20, 2015
@troygoode
Merge pull request #53 from telepharm/fixstrictobject
a28c7b2 
fix strict mode for node version past 0.10
@troygoode troygoode merged commit a28c7b2 into expressjs:master Jul 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordandenison @troygoode