Allow array of conditions as options.origin #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,23 +12,54 @@ | |||
| preflightContinue: false | |||
| }; | |||
|
|
|||
| function varyHeadersOn(vary, headers) { | |||
There was a problem hiding this comment.
@alex94puchades I'm a bit confused on what this function is doing. can you walk me through it?
There was a problem hiding this comment.
@troygoode It appends a vary header with the passed fields as value. It's easier when used like this:
varyHeadersOn('Origin', headers); // intended to read as varyHeadersOnOrigin(headers)Its only use is not having to repeat all the key-value vary header boilerplate.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fully addresses #42. It allows options.origin to be an array of all types currently supported in options.origin (String and RegExp). Unit tests added.