Optimize applyHeaders by removing the closure #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@troygoode Any chance to review the PR? |
|
That looks good @raymondfeng. I'll merge & release on npm. |
troygoode
added a commit
that referenced
this pull request
Jan 20, 2015
Optimize applyHeaders by removing the closure
|
@raymondfeng This has been released to npm as version |
|
@troygoode Thank you for the trust! |
|
No problem @raymondfeng. I love the work you guys at doing at StrongLoop. Sorry I didn't see the PR last week - somehow slipped through my inbox! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR improves the performance for the CORS middleware: