Add sdk names and versions to the client metadata #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Why
The correct metadata showing
sentry-expoand undelaying SDKs speedups solving issues related to the SDKs.How
This uses the Sentry client option
_metadata.https://github.com/getsentry/sentry-javascript/blob/eb898f5ba77efa0df84c8aa630113cfeb427d01e/packages/types/src/options.ts#L197
Test Plan
Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.
I've built the SDK locally and added it to my project to verify that the correct metadata is being sent.
Currently in RN the SDK name and version are overwritten, but the package array holds the correct data, so it's not blocking this PR. Fix here getsentry/sentry-react-native#3036