[ios] Fix crash when enabling Performance Monitor on iOS 13.4 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsapeta
approved these changes
Mar 30, 2020
| // As of iOS 13.4, it is no longer possible to change the JavaScriptCore | ||
| // options at runtime. The options are protected and will cause an | ||
| // exception when you try to change them after the VM has been initialized. | ||
| // https://github.com/facebook/react-native/issues/28414 |
brentvatne
approved these changes
Mar 30, 2020
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Apr 4, 2020
Summary: This PR fixes a crash when opening the Performance Monitor on iOS 13.4. Detailed info: #28414 ## Changelog `[iOS] [Fixed] - Fix crash when enabling Performance Monitor on iOS 13.4` ## How This PR prevents the JavaScriptCore option from being set altogether. This ensures that the performance monitor keeps working, but on iOS 13.4 and higher, it will no longer crash trying to show the GC usage. Pull Request resolved: #28512 Test Plan: Tested on iOS 13.4 (simulator):  Tested on iOS 13.1 (simulator)  - Verified that the `setOption` was called, but the Performance Monitor didn't show any GC usage regardless. - Identical PR expo#21 has been shipped and tested in Expo Client 37 Fixes #28414 Reviewed By: PeteTheHeat Differential Revision: D20851131 Pulled By: TheSavior fbshipit-source-id: ff96301036e8487db59f95947bbe6841fe230e1e
alloy
pushed a commit
to facebook/react-native
that referenced
this pull request
Apr 8, 2020
Summary: This PR fixes a crash when opening the Performance Monitor on iOS 13.4. Detailed info: #28414 ## Changelog `[iOS] [Fixed] - Fix crash when enabling Performance Monitor on iOS 13.4` ## How This PR prevents the JavaScriptCore option from being set altogether. This ensures that the performance monitor keeps working, but on iOS 13.4 and higher, it will no longer crash trying to show the GC usage. Pull Request resolved: #28512 Test Plan: Tested on iOS 13.4 (simulator):  Tested on iOS 13.1 (simulator)  - Verified that the `setOption` was called, but the Performance Monitor didn't show any GC usage regardless. - Identical PR expo#21 has been shipped and tested in Expo Client 37 Fixes #28414 Reviewed By: PeteTheHeat Differential Revision: D20851131 Pulled By: TheSavior fbshipit-source-id: ff96301036e8487db59f95947bbe6841fe230e1e
sasurau4
pushed a commit
to sasurau4/react-native
that referenced
this pull request
Apr 15, 2020
Summary: This PR fixes a crash when opening the Performance Monitor on iOS 13.4. Detailed info: facebook#28414 ## Changelog `[iOS] [Fixed] - Fix crash when enabling Performance Monitor on iOS 13.4` ## How This PR prevents the JavaScriptCore option from being set altogether. This ensures that the performance monitor keeps working, but on iOS 13.4 and higher, it will no longer crash trying to show the GC usage. Pull Request resolved: facebook#28512 Test Plan: Tested on iOS 13.4 (simulator):  Tested on iOS 13.1 (simulator)  - Verified that the `setOption` was called, but the Performance Monitor didn't show any GC usage regardless. - Identical PR expo#21 has been shipped and tested in Expo Client 37 Fixes facebook#28414 Reviewed By: PeteTheHeat Differential Revision: D20851131 Pulled By: TheSavior fbshipit-source-id: ff96301036e8487db59f95947bbe6841fe230e1e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes a crash when opening the Performance Monitor on iOS 13.4.
More info: facebook#28414
How
This PR prevents the JavaScriptCore option from being set altogether.
This ensures that the performance monitor keeps working, but on iOS 13.4 and higher, it will no longer crash or show the GC usage.
Test Plan
Tested on iOS 13.4 (simulator):
Tested on iOS 13.1 (simulator)
setOptionwas called, but the Performance Monitor didn't show any GC usage regardless.Release Notes
[ IOS ] [ BUGFIX ] [RCTPerfMonitor.m] - Fix crash when enabling Performance Monitor on iOS 13.4