Skip to content

Commit

Permalink
Merge base AppleTVOS flags into base Apple flags (take #5)
Browse files Browse the repository at this point in the history
Summary:
Previous iterations of this diff that were reverted: D30678341 (facebook@8009459), D30868627 (facebook@abd0f38),
D31024459 (facebook@0a46e5e), D31147242 (facebook@92c1bee).

With the power of selects, we can move the base AppleTVOS flags into the regular
base Apple flags.

Changelog: [Internal]

skip-frl-buck-targeting

Reviewed By: mzlee

Differential Revision: D31216242

fbshipit-source-id: 93ee2afda41af06fe210ba6a4a5459a438d6c3f8
  • Loading branch information
jdonald authored and facebook-github-bot committed Sep 29, 2021
1 parent a1c445a commit f09beea
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions BUCK
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native")
load("//tools/build_defs/apple:config_utils_defs.bzl", "STATIC_LIBRARY_APPLETVOS_CONFIG", "fbobjc_configs")
load("//tools/build_defs/apple:fb_apple_test.bzl", "fb_apple_test")
load("//tools/build_defs/apple:flag_defs.bzl", "get_base_appletvos_flags", "get_objc_arc_preprocessor_flags", "get_preprocessor_flags_for_build_mode", "get_static_library_ios_flags")
load("//tools/build_defs/apple:flag_defs.bzl", "get_objc_arc_preprocessor_flags", "get_preprocessor_flags_for_build_mode", "get_static_library_ios_flags")
load("//tools/build_defs/apple/plugins:plugin_defs.bzl", "plugin")
load("//tools/build_defs/oss:metro_defs.bzl", "rn_library")
load(
Expand Down Expand Up @@ -184,8 +183,6 @@ rn_xplat_cxx_library2(
prefix = "React",
),
apple_sdks = (IOS, APPLETVOS),
appletvos_configs = fbobjc_configs(STATIC_LIBRARY_APPLETVOS_CONFIG),
appletvos_inherited_buck_flags = get_base_appletvos_flags(),
contacts = ["oncall+react_native@xmail.facebook.com"],
fbobjc_enable_exceptions = True,
frameworks = [
Expand Down

0 comments on commit f09beea

Please sign in to comment.