[ios][camera] Fix path where camera saves picture on simulator #20872
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When taking photo using
takePictureAsync
there is a specific implementation for the simulator.However when building the directory where the file will be save, there is a small bug with the concatenation. The concatenation with the cacheDirectory is missing the slash (
/
) so it creates a folder calledCachesCamera
rather thanCaches/Camera
as the device implementation does.This creates an issue because FileSystem can't access this folder thus files can't be deleted. This issue creates in inconsistency between development environment and real device.
How
I added a slash
/
to the string. Assuming this implementation works only on simulator which works only on macOS, the file system will always use/
as directory separator so I believe we can just add this missing/
Test Plan
Use
expo-camera
and call the method takePictureAsync. Check the uri of the file generated.Checklist
expo prebuild
& EAS Build (eg: updated a module plugin).