Skip to content
This repository has been archived by the owner on Feb 15, 2019. It is now read-only.

React.PropTypes => PropTypes, redux ^5.0.6 #492

Merged
merged 2 commits into from
Aug 23, 2017
Merged

React.PropTypes => PropTypes, redux ^5.0.6 #492

merged 2 commits into from
Aug 23, 2017

Conversation

isnifer
Copy link
Contributor

@isnifer isnifer commented Aug 9, 2017

Hey, @skevy @brentvatne @janicduplessis please, take a look!
At Tipsi we want to upgrade our app to RN 0.47 because the App even can't start.
This PR brings prop-types into ex-navigation 👍
Also, I've update react-redux and fix paths to storeShape.

Please, publish updated version into npm we are waiting for you 😢

@isnifer isnifer changed the title React.PropTypes => PropTypes React.PropTypes => PropTypes, redux ^5.0.6 Aug 9, 2017
Copy link

@itsmepetrov itsmepetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge

@isnifer
Copy link
Contributor Author

isnifer commented Aug 10, 2017

Is anyone here?
image

@skevy @brentvatne @janicduplessis

@isnifer
Copy link
Contributor Author

isnifer commented Aug 11, 2017

Hey @skevy @brentvatne @janicduplessis, where are you?

@isnifer
Copy link
Contributor Author

isnifer commented Aug 13, 2017

@skevy @brentvatne @janicduplessis
image

@brentvatne
Copy link
Member

@isnifer - I don't work on this anymore, we are moving to ex-navigation, do you want to be a maintainer of this project?

@isnifer
Copy link
Contributor Author

isnifer commented Aug 21, 2017

@brentvatne this project is ex-navigation, haha. If I need to be a maintainer to merge this PR, OK I will)

@brentvatne
Copy link
Member

lol oops, I meant react-navigation :P

@brentvatne brentvatne merged commit 3166a2a into expo:master Aug 23, 2017
@brentvatne
Copy link
Member

published in 3.1.0

@isnifer
Copy link
Contributor Author

isnifer commented Aug 23, 2017

Awesome, thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants