Skip to content
This repository has been archived by the owner on Feb 15, 2019. It is now read-only.

Commit

Permalink
use react-native-drawer-layout-polyfill
Browse files Browse the repository at this point in the history
react-native-drawer-layout switched to a JS based implementation even on android without a major version bump. Interaction handles are not cleared properly in the JS implementation and that broke our android app. polyfill uses native implementation on android which i feel has much better experience.

cc @satya164 @brentvatne @skevy

Closes #430

fbshipit-source-id: 9b66f04
  • Loading branch information
chirag04 authored and expbot committed Mar 20, 2017
1 parent 35b2340 commit 6562c67
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"react-addons-shallow-compare": "15.3.2",
"react-clone-referenced-element": "^1.0.1",
"react-mixin": "^3.0.5",
"react-native-drawer-layout": "^1.0.0",
"react-native-drawer-layout-polyfill": "^1.1.0",
"react-native-tab-view": "0.0.52",
"react-redux": "^4.4.5",
"react-static-container": "^1.0.0",
Expand All @@ -47,9 +47,8 @@
},
"devDependencies": {
"babel-eslint": "^7.1.1",
"eslint": "^3.0.0",
"eslint-config-expo": "^5.1.3",
"eslint": "^3.12.2",
"eslint-config-expo": "^5.1.3",
"eslint-plugin-babel": "^4.0.0",
"eslint-plugin-flowtype": "^2.30.0",
"eslint-plugin-import": "^2.2.0",
Expand Down
2 changes: 1 addition & 1 deletion src/drawer/ExNavigationDrawer.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
StyleSheet,
View,
} from 'react-native';
import DrawerLayout from 'react-native-drawer-layout';
import DrawerLayout from 'react-native-drawer-layout-polyfill';
import PureComponent from '../utils/PureComponent';
import StaticContainer from 'react-static-container';

Expand Down
2 changes: 1 addition & 1 deletion src/drawer/ExNavigationDrawerLayout.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
TouchableWithoutFeedback,
View,
} from 'react-native';
import DrawerLayout from 'react-native-drawer-layout';
import DrawerLayout from 'react-native-drawer-layout-polyfill';
import TouchableNativeFeedbackSafe
from '@expo/react-native-touchable-native-feedback-safe';

Expand Down

0 comments on commit 6562c67

Please sign in to comment.