Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] use existing google service account key #650

Merged
merged 4 commits into from
Sep 28, 2021

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Sep 28, 2021

Checklist

  • I've added an entry to CHANGELOG.md if necessary.
  • I've tagged the changelog entry with [EAS BUILD API] if it's a part of a breaking change to EAS Build API (only possible when updating @expo/eas-build-job package).

Why

This PR:

  • allows the user to assign an existing GoogleServiceAccountKey to their project on the www servers
  • adds an action to assign an existing key in the credentials management workflow

It will also eventually be used in the submissions workflow.

Test Plan

  • new tests pass
  • manually tested new credentials management action

@quinlanj quinlanj changed the base branch from main to @quin/assignGsaKey September 28, 2021 04:50
@github-actions
Copy link

github-actions bot commented Sep 28, 2021

Size Change: +2.17 kB (0%)

Total Size: 27 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 27 MB +2.17 kB (0%)

compressed-size-action

@quinlanj quinlanj force-pushed the @quin/useExistingGsakey branch from 71094b7 to 64ee710 Compare September 28, 2021 04:55
Base automatically changed from @quin/assignGsaKey to main September 28, 2021 21:54
@quinlanj quinlanj force-pushed the @quin/useExistingGsakey branch from 0f772af to 4b95b1d Compare September 28, 2021 21:58
@quinlanj quinlanj merged commit 4674cbe into main Sep 28, 2021
@quinlanj quinlanj deleted the @quin/useExistingGsakey branch September 28, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants