Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix experience with validating metro config in non-interactive mode #644

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

dsokal
Copy link
Contributor

@dsokal dsokal commented Sep 24, 2021

Checklist

  • I've added an entry to CHANGELOG.md if necessary.
  • I've tagged the changelog entry with [EAS BUILD API] if it's a part of a breaking change to EAS Build API (only possible when updating @expo/eas-build-job package).

Why

Fixes #643

How

Check if running in non-interactive mode and proceed even if the metro config seems invalid

Test Plan

Screenshot 2021-09-24 at 10 40 04

@dsokal dsokal marked this pull request as ready for review September 24, 2021 08:44
@dsokal dsokal requested a review from wkozyra95 September 24, 2021 08:44
@github-actions
Copy link

github-actions bot commented Sep 24, 2021

Size Change: -809 B (0%)

Total Size: 27 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 27 MB -809 B (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #644 (120828a) into main (0bce278) will decrease coverage by 0.02%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
- Coverage   48.77%   48.75%   -0.01%     
==========================================
  Files         304      304              
  Lines       10492    10497       +5     
  Branches     1981     1983       +2     
==========================================
+ Hits         5116     5117       +1     
- Misses       5371     5375       +4     
  Partials        5        5              
Impacted Files Coverage Δ
packages/eas-cli/src/project/metroConfig.ts 14.64% <12.50%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bce278...120828a. Read the comment docs.

@dsokal dsokal merged commit fe0a3b4 into main Sep 24, 2021
@dsokal dsokal deleted the @dsokal/proceed-in-non-interactive-mode branch September 24, 2021 09:35
@bensig
Copy link

bensig commented Sep 24, 2021

Thank you @dsokal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eas build --non-interactive requires (certain) interactions
3 participants