Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use log-symbols to unify green ticks style #639

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Conversation

dsokal
Copy link
Contributor

@dsokal dsokal commented Sep 23, 2021

Checklist

  • I've added an entry to CHANGELOG.md if necessary.
  • I've tagged the changelog entry with [EAS BUILD API] if it's a part of a breaking change to EAS Build API (only possible when updating @expo/eas-build-job package).

Why

The green ticks style is not consistent. Reported by @EvanBacon on Slack.

Screen Shot 2021-09-22 at 6 18 21 PM

How

Use log-symbols (ora is using it under the hood) to unify green ticks style.

Test Plan

Screenshot 2021-09-23 at 09 52 00

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #639 (14204ab) into main (2f57fd1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
+ Coverage   48.94%   48.95%   +0.01%     
==========================================
  Files         304      304              
  Lines       10487    10488       +1     
  Branches     1980     1980              
==========================================
+ Hits         5132     5133       +1     
  Misses       5350     5350              
  Partials        5        5              
Impacted Files Coverage Δ
packages/eas-cli/src/log.ts 79.32% <100.00%> (+0.37%) ⬆️
packages/eas-cli/src/utils/progress.ts 29.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f57fd1...14204ab. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 23, 2021

Size Change: +1.54 kB (0%)

Total Size: 27 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 27 MB +1.54 kB (0%)

compressed-size-action

@dsokal dsokal requested a review from wkozyra95 September 23, 2021 07:53
@dsokal dsokal marked this pull request as ready for review September 23, 2021 07:53
@dsokal dsokal requested a review from barthap September 23, 2021 07:53
@dsokal dsokal merged commit 1e419ab into main Sep 23, 2021
@dsokal dsokal deleted the @dsokal/unify-green-ticks branch September 23, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants