[ENG-1792] Validate that project includes expo-dev-client when building with developmentClient flag #627
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[EAS BUILD API]
if it's a part of a breaking change to EAS Build API (only possible when updating@expo/eas-build-job
package).Why
https://linear.app/expo/issue/ENG-1792/validate-that-project-includes-expo-dev-client-when-building-with
We want to validate that project includes
expo-dev-client
when building withdevelopmentClient
flag.How
If
developmentClient
is set totrue
butexpo-dev-client
is not installed:expo install ...
and then commit the changesexpo-dev-client
if they don't proceedTest Plan
Tested manually.
Managed project:
![Screenshot 2021-09-17 at 12 57 20](https://user-images.githubusercontent.com/5256730/133771725-23b2e3ef-da2e-4357-b6dd-39270f44cbf3.png)
Bare project:
![Screenshot 2021-09-17 at 12 54 42](https://user-images.githubusercontent.com/5256730/133771428-0b47f152-1d28-49bb-acd5-3de8ee33b958.png)