Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-1792] Validate that project includes expo-dev-client when building with developmentClient flag #627

Merged
merged 6 commits into from
Sep 20, 2021

Conversation

dsokal
Copy link
Contributor

@dsokal dsokal commented Sep 17, 2021

Checklist

  • I've added an entry to CHANGELOG.md if necessary.
  • I've tagged the changelog entry with [EAS BUILD API] if it's a part of a breaking change to EAS Build API (only possible when updating @expo/eas-build-job package).

Why

https://linear.app/expo/issue/ENG-1792/validate-that-project-includes-expo-dev-client-when-building-with
We want to validate that project includes expo-dev-client when building with developmentClient flag.

How

If developmentClient is set to true but expo-dev-client is not installed:

  • [managed] offer to install the package with expo install ... and then commit the changes
  • [bare] ask the user if they want to proceed, and print instructions on how to install expo-dev-client if they don't proceed

Test Plan

Tested manually.

Managed project:
Screenshot 2021-09-17 at 12 57 20

Bare project:
Screenshot 2021-09-17 at 12 54 42

@github-actions
Copy link

github-actions bot commented Sep 17, 2021

Size Change: +155 B (0%)

Total Size: 27.1 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 27.1 MB +155 B (0%)

compressed-size-action

@dsokal dsokal marked this pull request as ready for review September 17, 2021 11:08
@dsokal dsokal merged commit eef0c6a into main Sep 20, 2021
@dsokal dsokal deleted the @dsokal/dev-client-check branch September 20, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants