enforce Async suffix for async functions #623
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[EAS BUILD API]
if it's a part of a breaking change to EAS Build API (only possible when updating@expo/eas-build-job
package).Why
We use
Async
suffix for async functions. Unfortunately, we haven't had any eslint rule that would enforce that convention.How
async-protect/async-suffix
rule for all files except tests and mocks (mostly becausejest.fn()
does not return an async function).EasCommand
class. This let me avoid adding theeslint-disable-next-line
statement in every command class. (cc @kgc00)Test Plan
CI