Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-1347] eas submit: suggest using build id instead of build details page #620

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

dsokal
Copy link
Contributor

@dsokal dsokal commented Sep 15, 2021

Checklist

  • I've added an entry to CHANGELOG.md if necessary.
  • I've tagged the changelog entry with [EAS BUILD API] if it's a part of a breaking change to EAS Build API (only possible when updating @expo/eas-build-job package).

Why

https://linear.app/expo/issue/ENG-1347/improve-feedback-when-user-enters-incorrect-url-for-build-eas-submit

How

Detect if the user provided the build details page URL as the build artifact URL and ask if they know what they're doing. EAS CLI parses the URL and suggests submitting the build with the id from the URL.

Test Plan

Tested manually + unit test.

Screenshot 2021-09-15 at 17 10 05

@github-actions
Copy link

github-actions bot commented Sep 15, 2021

Size Change: +749 B (0%)

Total Size: 27.1 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 27.1 MB +749 B (0%)

compressed-size-action

@dsokal dsokal marked this pull request as ready for review September 15, 2021 15:09
@dsokal dsokal changed the title eas submit: suggest using build id instead of build details page [ENG-1347] eas submit: suggest using build id instead of build details page Sep 15, 2021
@linear
Copy link

linear bot commented Sep 15, 2021

ENG-1347 Improve feedback when user enters incorrect URL for build: `eas submit --url `

https://forums.expo.io/t/eas-submit-wont-work-but-transporter-will/53362/11?u=notbrent

We may want to add a special case check for users providing a URL to the build page rather than the artifact

@dsokal dsokal force-pushed the @dsokal/submit-build-details-url branch from 97fc1d0 to 4403c80 Compare September 16, 2021 09:55
@dsokal dsokal merged commit 95e8a38 into main Sep 16, 2021
@dsokal dsokal deleted the @dsokal/submit-build-details-url branch September 16, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants