[ENG-1396] change default ios image for sdk <= 41 #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-1396 Make "default" image dependent on SDK version
SDK 41 projects may not build with Xcode 12.5, so we can't change the "default" from Xcode 12.4 to 12.5 or we may break their project. This may in the future mean that you won't be able to submit your older project to the store without manually switching the |
f7a1096 to
eda339d
Compare
|
Size Change: -395 B (0%) Total Size: 37.6 MB
|
eda339d to
c556053
Compare
c556053 to
02fba5c
Compare
wkozyra95
approved these changes
Jun 25, 2021
CHANGELOG.md
Outdated
| @@ -6,6 +6,8 @@ This is the log of notable changes to EAS CLI and related packages. | |||
|
|
|||
| ### 🛠 Breaking changes | |||
|
|
|||
| - Change default iOS image for projects with Expo SDK <= 41 (SDK 41 won't build with Xcode 12.5). ([#479](https://github.com/expo/eas-cli/pull/479) by [@dsokal](https://github.com/dsokal)) | |||
There was a problem hiding this comment.
it's not breaking change because the current default is still set to macos-catalina-10.15-xcode-12.4
02fba5c to
b1a3263
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[EAS BUILD API]if it's a part of a breaking change to EAS Build API (only possible when updating@expo/eas-build-jobpackage).Why
https://linear.app/expo/issue/ENG-1396/make-default-image-dependent-on-sdk-version
Expo SDK 41 (and lower) projects won't build with Xcode 12.5.
How
If we detect that a project uses SDK <= 41 we use image
macos-catalina-10.15-xcode-12.4.Test Plan
imageineas.json. I saw thatmacos-catalina-10.15-xcode-12.4was used for the build.imageset ineas.json. The image was propagated to the job object.