Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-1395] support new build status: new #475

Merged
merged 2 commits into from
Jun 24, 2021
Merged

[ENG-1395] support new build status: new #475

merged 2 commits into from
Jun 24, 2021

Conversation

dsokal
Copy link
Contributor

@dsokal dsokal commented Jun 24, 2021

Checklist

  • I've added an entry to CHANGELOG.md if necessary.
  • I've tagged the changelog entry with [EAS BUILD API] if it's a part of a breaking change to EAS Build API (only possible when updating @expo/eas-build-job package).

Why

new is now the initial build status. A build is in this state when it's not yet enqueued. This can happen when the account reaches the concurrency limit.

Part of https://linear.app/expo/issue/ENG-1395/add-status-to-reflect-prequeue-state-to-www
www PR: https://github.com/expo/universe/pull/7756

How

  • I grepped the repo for BuildStatus and added support for the new status.
  • Deleted getPendingBuildIdAsync as it hasn't been used anywhere.

Test Plan

I ran a build in staging and the CLI didn't break.

@dsokal dsokal changed the title support new build status: 'new' support new build status: new Jun 24, 2021
@dsokal dsokal force-pushed the @dsokal/new-status branch from cca7363 to c9b91b6 Compare June 24, 2021 09:38
@dsokal dsokal requested a review from wkozyra95 June 24, 2021 09:42
@dsokal dsokal marked this pull request as ready for review June 24, 2021 09:42
@github-actions
Copy link

Size Change: -1.67 kB (0%)

Total Size: 37.6 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 37.6 MB -1.67 kB (0%)

compressed-size-action

@dsokal dsokal merged commit 5228181 into main Jun 24, 2021
@dsokal dsokal deleted the @dsokal/new-status branch June 24, 2021 10:07
@dsokal dsokal changed the title support new build status: new [ENG-1395] support new build status: new Jun 25, 2021
@linear
Copy link

linear bot commented Jun 25, 2021

ENG-1395 Add status to reflect "prequeue" state to www

Currently we don't reflect "prequeue" in the build web UI, but this is useful for developers to know if they are constrained by their concurrencies (which they can act on to resolve by adding more to their account)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants