Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] make apple team optional in appropriate cases #468

Merged
merged 2 commits into from
Jun 25, 2021

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Jun 18, 2021

why

Make Apple Team optional in the following cases:

  • to create IosAppCredentials (see https://github.com/expo/universe/pull/7740 for more details)
  • to create an explicit bundle identifier (AppleAppIdentifier). Bundle identifiers are like domain names -- once you claim sdf.sdf.sdf, no one else can use it. But in the case where someone has a wildcard bundle identifier like sdf.sdf.*, it only matches to bundle identifiers your Apple Team owns. For example, Alice's wildcard identifier sdf.sdf.*only applies to sdf.alice because it's owned by her, but it will not apply to sdf.bob because it's owned by Bob. Therefore, its important we know the Apple Team sdf.sdf.* belongs to, but it's not required for explicit identifiers like sdf.sdf.

prereqs

@quinlanj quinlanj force-pushed the @quin/makeAppleTeamOptional branch from 9ee326e to e124050 Compare June 23, 2021 21:18
@quinlanj quinlanj changed the title [eas-cli] make apple team optional to make iosappcredentials [eas-cli] make apple team optional in appropriate cases Jun 23, 2021
@github-actions
Copy link

github-actions bot commented Jun 23, 2021

Size Change: -737 B (0%)

Total Size: 37.6 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 37.6 MB -737 B (0%)

compressed-size-action

@quinlanj quinlanj requested a review from wkozyra95 June 23, 2021 21:24
@quinlanj quinlanj marked this pull request as ready for review June 23, 2021 21:25
@quinlanj quinlanj merged commit db29b3f into main Jun 25, 2021
@quinlanj quinlanj deleted the @quin/makeAppleTeamOptional branch June 25, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants