Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an internal distribution with dev client to build:configure defaults #465

Merged
merged 3 commits into from
Jun 21, 2021

Conversation

fson
Copy link
Contributor

@fson fson commented Jun 17, 2021

Checklist

  • I've added an entry to CHANGELOG.md if necessary.
  • I've tagged the changelog entry with [EAS BUILD API] if it's a part of a breaking change to EAS Build API (only possible when updating @expo/eas-build-job package).

Why

It should be easy to make a build for internal distribution with dev client included.

How

Automatically configure a build profile for internal distribution in eas.json when eas build:configure is run.

I did this by modifying the default values added to eas.json.

Test Plan

Ran eas build:configure -p all in a managed app. Contents of eas.json:

{
  "builds": {
    "android": {
      "release": {
        "workflow": "managed"
      },
      "development": {
        "workflow": "managed",
        "buildType": "development-client",
        "distribution": "internal"
      }
    },
    "ios": {
      "release": {
        "workflow": "managed"
      },
      "development": {
        "workflow": "managed",
        "buildType": "development-client",
        "distribution": "internal"
      }
    }
  }
}

Ran eas build:configure -p all in a bare app. Contents of eas.json:

{
  "builds": {
    "android": {
      "release": {
        "workflow": "generic"
      },
      "development": {
        "workflow": "generic",
        "gradleCommand": ":app:assembleDebug",
        "distribution": "internal"
      }
    },
    "ios": {
      "release": {
        "workflow": "generic"
      },
      "development": {
        "workflow": "generic",
        "schemeBuildConfiguration": "Debug",
        "distribution": "internal"
      }
    }
  }
}

@linear
Copy link

linear bot commented Jun 17, 2021

ENG-1202 Update eas build:configure to provide internal distribution for dev client

Aligned with the scheme in docs.expo.io/clients/eas-build

  • managed projects can be immediately built through EAS after running build:configure
  • bare projects can be immediately built through EAS after running build:configure

@fson fson requested a review from brentvatne June 17, 2021 15:05
@github-actions
Copy link

github-actions bot commented Jun 17, 2021

Size Change: +355 B (0%)

Total Size: 37.6 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 37.6 MB +355 B (0%)

compressed-size-action

@brentvatne
Copy link
Member

@fson fson requested a review from wkozyra95 June 17, 2021 19:56
@fson fson merged commit fff7aac into main Jun 21, 2021
@fson fson deleted the ville/eng-1202-update-eas-buildconfigure-to-provide branch June 21, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants