Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] action to upload/download credentials.json to www #455

Merged
merged 3 commits into from
Jun 15, 2021

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Jun 15, 2021

Checklist

  • I've added an entry to CHANGELOG.md if necessary.
  • I've tagged the changelog entry with [EAS BUILD API] if it's a part of a breaking change to EAS Build API (only possible when updating @expo/eas-build-job package).

Why

This is part of the effort to move all credentials apiv2 calls to our graphql api. This PR allows you to update/download build credentials between your local credentials.json and the EAS servers using the new Graphql Api. This is what will eventually replace the old SetupBuildCredentialsFromCredentialsJson and UpdateCredentialsJson here: https://github.com/expo/eas-cli/blob/main/packages/eas-cli/src/credentials/android/actions/SetupBuildCredentials.ts and https://github.com/expo/eas-cli/blob/main/packages/eas-cli/src/credentials/android/actions/UpdateCredentialsJson.ts

Test Plan

  • amended and new tests pass
  • manual sanity testing

@quinlanj quinlanj requested review from dsokal and wkozyra95 June 15, 2021 01:51
@github-actions
Copy link

github-actions bot commented Jun 15, 2021

Size Change: -1.27 kB (0%)

Total Size: 37.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 37.5 MB -1.27 kB (0%)

compressed-size-action

Copy link
Contributor

@dsokal dsokal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

quinlanj and others added 2 commits June 15, 2021 11:13
…dCredentialsFromCredentialsJson.ts

Co-authored-by: Dominik Sokal <dominik.sokal@swmansion.com>
…ialsJson.ts

Co-authored-by: Dominik Sokal <dominik.sokal@swmansion.com>
@quinlanj quinlanj merged commit 242da62 into main Jun 15, 2021
@quinlanj quinlanj deleted the @quin/updateAndroidCreds branch June 15, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants