Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-1242][eas-cli] copy Expo Classic credentials to EAS if user is eligible #445

Merged
merged 4 commits into from
Jun 9, 2021

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Jun 7, 2021

Checklist

  • I've added an entry to CHANGELOG.md if necessary.
  • I've tagged the changelog entry with [EAS BUILD API] if it's a part of a breaking change to EAS Build API (only possible when updating @expo/eas-build-job package).

Why

  • If the user hasn't set up any credentials in EAS but has credentials in Expo Classic (expo-cli), copy them over. We will give users this option if they are running eas build:android or using the beta credentials manager.
  • This change will allow us to disregard Expo Classic (expo-cli) credentials in the future and simplify logic because if a user is no longer eligible for a 'copy', we can assume that the legacy credentials were already copied, or the user has chosen to create their EAS credentials from scratch.

User Experience

Screen Shot 2021-06-07 at 3 16 30 PM

  • User will be prompted to copy over their Expo Classic credentials
  • If they say no, and go on to create credentials in the EAS system, they will no longer be prompted on future builds because they are no longer eligible to have their Expo Classic credentials copied
  • If they say yes, all credentials from Expo Classic will be copied to the EAS system

Test Plan

  • new tests pass
  • manual sanity checks

@quinlanj quinlanj requested review from dsokal, wkozyra95 and FiberJW June 7, 2021 22:23
@linear
Copy link

linear bot commented Jun 7, 2021

@github-actions
Copy link

github-actions bot commented Jun 7, 2021

Size Change: +2.22 kB (0%)

Total Size: 37.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 37.5 MB +2.22 kB (0%)

compressed-size-action

Copy link
Contributor

@FiberJW FiberJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor

@quinlanj quinlanj merged commit 2486a4d into main Jun 9, 2021
@quinlanj quinlanj deleted the @quin/copyCreds branch June 9, 2021 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants