Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eas-cli] refactor credential input types #443

Merged
merged 3 commits into from
Jun 7, 2021
Merged

[eas-cli] refactor credential input types #443

merged 3 commits into from
Jun 7, 2021

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Jun 5, 2021

Checklist

  • I've added an entry to CHANGELOG.md if necessary.
  • I've tagged the changelog entry with [EAS BUILD API] if it's a part of a breaking change to EAS Build API (only possible when updating @expo/eas-build-job package).

Why

cleanup input types to use the generated ones

Test Plan

  • everything still passes

@quinlanj quinlanj requested review from dsokal and wkozyra95 June 5, 2021 00:10
@quinlanj quinlanj changed the title @quin/refactor input [www] refactor credential input types Jun 5, 2021
@quinlanj quinlanj changed the title [www] refactor credential input types [eas-cli] refactor credential input types Jun 5, 2021
@github-actions
Copy link

github-actions bot commented Jun 5, 2021 •
edited
Loading

Size Change: -1.11 kB (0%)

Total Size: 37.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 37.5 MB -1.11 kB (0%)

compressed-size-action

dsokal
dsokal approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@dsokal dsokal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@quinlanj quinlanj merged commit 265ba16 into main Jun 7, 2021
@quinlanj quinlanj deleted the @quin/refactorInput branch June 7, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsokal dsokal dsokal approved these changes

@wkozyra95 wkozyra95 wkozyra95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quinlanj @dsokal @wkozyra95