Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Deprecate --skip-credentials-check flag for build #442

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

brentvatne
Copy link
Member

@brentvatne brentvatne commented Jun 4, 2021

Checklist

  • I've added an entry to CHANGELOG.md if necessary.
  • [n/a] I've tagged the changelog entry with [EAS BUILD API] if it's a part of a breaking change to EAS Build API (only possible when updating @expo/eas-build-job package).

Why

Context in https://linear.app/expo/issue/ENG-1103/remove-skip-credentials-check

How

  • Delete usage of skipCredentialsCheck
  • Add warning to when the --skip-credentials-check flag is passed in to eas build
  • Create a logging helper that we can use for future flag deprecations to ensure we have a consistent format (using the same format as expo-cli, eg: run expo start --config example.json anywhere to see a similar warning.
  • Hide the flag from eas build --help

Test Plan

Flag is hidden from help

╰─$ easd build --help
Start a build

USAGE
  $ eas build

OPTIONS
  --clear-cache                     Clear cache before the build
  --local                           Run build locally [experimental]
  --non-interactive                 Run command in --non-interactive mode
  -p, --platform=(android|ios|all)
  --profile=profile                 [default: release] Name of the build profile from eas.json
  --skip-project-configuration      Skip project configuration
  --[no-]wait                       Wait for build(s) to complete

COMMANDS
  build:cancel     Cancel a build.
  build:configure  Configure the project to support EAS Build.
  build:list       list all builds for your project
  build:view       view a build for your project

Warning is printed when flag is used

Screen Shot 2021-06-10 at 8 09 34 PM

@brentvatne brentvatne requested a review from wkozyra95 June 4, 2021 17:47
@linear
Copy link

linear bot commented Jun 4, 2021

ENG-1103 Remove --skip-credentials-check

╭─~/code/easmanaged ‹main›
╰─$ eas build -p ios --skip-credentials-check
✔ Linked to project @charliecruzan/easmanaged
✔ Using remote iOS credentials (Expo server)
If you provide your Apple account credentials we will be able to generate all necessary build credentials and fully validate them.
This is optional, but without Apple account access you will need to provide all the values manually and we can only run minimal validation on them.
✔ Do you want to log in to your Apple account? … no
No problem! 👌 If you select an action that requires those credentials we will ask you again about it.

It should not prompt to sign in with Apple account

Update: as per discussion in comments, this flag does not apply to iOS anymore (use --non-interactive instead) and it used to apply to Android but no longer actually does anything. So, we should remove it.

@github-actions
Copy link

github-actions bot commented Jun 4, 2021

Size Change: +834 B (0%)

Total Size: 37.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 37.5 MB +834 B (0%)

compressed-size-action

CHANGELOG.md Outdated Show resolved Hide resolved
packages/eas-cli/src/commands/build/index.ts Show resolved Hide resolved
@brentvatne brentvatne force-pushed the brent/eng-1103-remove---skip-credentials-check branch from 8104cd5 to 0b19074 Compare June 11, 2021 03:11
@brentvatne brentvatne changed the title Remove --skip-credentials-check flag for builds [eas-cli] Deprecate --skip-credentials-check flag for build Jun 11, 2021
@brentvatne brentvatne force-pushed the brent/eng-1103-remove---skip-credentials-check branch from 0b19074 to d96c1f4 Compare June 11, 2021 03:18
@brentvatne brentvatne merged commit b0d4ed6 into main Jun 11, 2021
@brentvatne brentvatne deleted the brent/eng-1103-remove---skip-credentials-check branch June 11, 2021 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants