[eas-cli] action to select android build credentials #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -1.26 kB (0%) Total Size: 37.5 MB
|
dsokal
reviewed
Jun 4, 2021
packages/eas-cli/src/credentials/manager/SelectAndroidBuildCredentials.ts
Outdated
Show resolved
Hide resolved
wkozyra95
approved these changes
Jun 4, 2021
9b40cc0 to
5f2dfb0
Compare
dsokal
approved these changes
Jun 7, 2021
|
👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[EAS BUILD API]if it's a part of a breaking change to EAS Build API (only possible when updating@expo/eas-build-jobpackage).Why
In the Android credentials manager, allow a way for users to choose their build credentials in the 'modern android credentials'.
How
beta credentials manager is a bit messy rn -- once i add the full suite of commands ill refactor it to smth that makes more sense
Test Plan