[eas-cli] use new android build credentials provider #427
Conversation
|
Size Change: +473 B (0%) Total Size: 37.5 MB
|
| projectName: ctx.commandCtx.projectName, | ||
| accountName: ctx.commandCtx.accountName, | ||
| androidApplicationIdentifier: nullthrows( |
There was a problem hiding this comment.
This value from app.json is not correct for generic projects. Actually, we even print a warning if someone is building a generic project and they have android.package defined in their app.json (see https://github.com/expo/eas-cli/blob/main/packages/eas-cli/src/project/android/applicationId.ts#L35). For generic, we read the application id from native code.
Take a look at line 70 in this file and use the value returned by the getOrConfigureApplicationIdAsync function.
| @@ -113,14 +115,22 @@ async function ensureAndroidCredentialsAsync( | |||
| if (!shouldProvideCredentials(ctx)) { | |||
| return; | |||
| } | |||
| const androidApplicationIdentifier = await getOrConfigureApplicationIdAsync( | |||
There was a problem hiding this comment.
| const androidApplicationIdentifier = await getOrConfigureApplicationIdAsync( | |
| const androidApplicationIdentifier = getApplicationId( |
This change is related to #431 (comment)
The application id must be already configured in this context.
There was a problem hiding this comment.
Sorry for making you change it again but in https://github.com/expo/eas-cli/pull/427/files/887877aaf9874f6b77a09f3c8632456d54f98355#r640438388 I meant to use the result of the call on line 70.
However, when I was reviewing #431 I realized that we should change the name (and behavior) of getOrConfigureApplicationIdAsync 😅
23c391b to
9ac5688
Compare
Checklist
[EAS BUILD API]if it's a part of a breaking change to EAS Build API (only possible when updating@expo/eas-build-jobpackage).Why
Replace the old Android SetupBuildCredentials with the new one
Test Plan