Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sending appBuildVersion to api #423

Merged
merged 3 commits into from
May 25, 2021

Conversation

dsokal
Copy link
Contributor

@dsokal dsokal commented May 25, 2021

Checklist

  • I've added an entry to CHANGELOG.md if necessary.
  • I've tagged the changelog entry with [EAS BUILD API] if it's a part of a breaking change to EAS Build API (only possible when updating @expo/eas-build-job package).

Why

I've found out that even though that #413 has been released, the appBuildVersion is not being sent to api.

This is because I forgot to do two things:

  • Regenerate graphql code
  • Update the metadata transformer

How

  • I regenerated GraphQL code.
  • I updated the metadata transformer so now it passes the appBuildVersion to the build mutation.

Test Plan

This time I double-checked that the appBuildVersion is sent with other metadata to the API (checked the records in db).

@dsokal dsokal requested a review from wkozyra95 May 25, 2021 13:32
@github-actions
Copy link

github-actions bot commented May 25, 2021

Size Change: +181 B (0%)

Total Size: 37.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 37.3 MB +181 B (0%)

compressed-size-action

@dsokal dsokal merged commit 97ff6f4 into main May 25, 2021
@dsokal dsokal deleted the @dsokal/fix-sending-app-version-to-api branch May 25, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants