Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use config introspection to get all entitlements #419

Merged
merged 7 commits into from
May 25, 2021

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented May 21, 2021

Checklist

Why

Enable auto capabilities for managed EAS projects by introspecting the app config. Introspection is a new config plugin feature which evaluates a subset of modifiers without persisting the results. This enables us to get the full results of the entitlements object.

(also slipped in a few assert fixes)

Test Plan

Using the following app.json in a managed EAS project should enable Push Notifications, Sign In with Apple, Associated Domains.

{
  "expo": {
    "ios": {
      "usesAppleSignIn": true,
      "associatedDomains": ["applinks:foobar"],
    }
  }
}

And you should see something like:

✔ Bundle identifier registered com.bacon.yolo24
✔ Synced capabilities: Enabled: Associated Domains, Sign In with Apple

Removing the values should show something like this:

✔ Synced capabilities: Disabled: Sign In with Apple, Associated Domains

Visiting the Apple developer portal for the bundle ID should show the expected capabilities https://developer.apple.com/account/resources/identifiers/bundleId/edit/XXXXXX

@github-actions
Copy link

github-actions bot commented May 21, 2021

Size Change: +5.53 MB (+17%) ⚠️

Total Size: 37.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 37.3 MB +5.53 MB (+17%) ⚠️

compressed-size-action

@EvanBacon EvanBacon requested a review from dsokal May 24, 2021 17:12
@EvanBacon EvanBacon merged commit bd39b29 into main May 25, 2021
@EvanBacon EvanBacon deleted the @evanbacon/eas-cli/introspect-managed-config branch May 25, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants